x86/vtd: Don't include control register state in the table pointers
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 18 Mar 2019 16:07:45 +0000 (17:07 +0100)
committerJan Beulich <jbeulich@suse.com>
Mon, 18 Mar 2019 16:07:45 +0000 (17:07 +0100)
commit4db8fddf7770b2c55bce8b98e37503c2d2a3c8c9
treed86a0cf230a8c1c516b284dd7d21c081a293bb59
parentc74683ae882fe2c260898865a92d90fc5f5f6b15
x86/vtd: Don't include control register state in the table pointers

iremap_maddr and qinval_maddr point to the base of a block of contiguous RAM,
allocated by the driver, holding the Interrupt Remapping table, and the Queued
Invalidation ring.

Despite their name, they are actually the values of the hardware register,
including control metadata in the lower 12 bits.  While uses of these fields
do appear to correctly shift out the metadata, this is very subtle behaviour
and confusing to follow.

Nothing uses the metadata, so make the fields actually point at the base of
the relevant tables.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
master commit: a9a05aeee10a5a3763a41305a9f38112dd1fcc82
master date: 2019-03-12 13:57:13 +0000
xen/drivers/passthrough/vtd/intremap.c
xen/drivers/passthrough/vtd/qinval.c
xen/drivers/passthrough/vtd/utils.c